GNOME Bugzilla – Bug 706137
Various build fixes
Last modified: 2013-08-16 15:15:39 UTC
See patches
Created attachment 251845 [details] [review] build: Don't install INSTALL Really, no one needs this on their system in the first place. But I'm specifically deleting it because it broke in the gnome-ostree build system; automake may have it be a symlink, and we don't want to install that.
Created attachment 251846 [details] [review] build: Fix srcdir != builddir The enum files are potentially in $(builddir), not $(srcdir); we should be able to just rely on Make's VPATH handling to DTRT.
Created attachment 251847 [details] [review] build: Fix enum generation First, drop the conditional on maintainer mode; we shouldn't rely on --enable-maintainer-mode to build the enums from git. Second, rework the style to fix srcdir != builddir, and avoid weird hardcoded tempfile names. This newer style can be found in the gnome-shell git for example.
Comment on attachment 251845 [details] [review] build: Don't install INSTALL Thanks for the patch!
Comment on attachment 251846 [details] [review] build: Fix srcdir != builddir Thanks for the patch!
Comment on attachment 251847 [details] [review] build: Fix enum generation Thanks for the patch!