After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706137 - Various build fixes
Various build fixes
Status: RESOLVED FIXED
Product: libzapojit
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libzapojit maintainer(s)
libzapojit maintainer(s)
Depends on:
Blocks: 706122
 
 
Reported: 2013-08-16 13:53 UTC by Colin Walters
Modified: 2013-08-16 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Don't install INSTALL (777 bytes, patch)
2013-08-16 13:53 UTC, Colin Walters
committed Details | Review
build: Fix srcdir != builddir (889 bytes, patch)
2013-08-16 13:53 UTC, Colin Walters
committed Details | Review
build: Fix enum generation (2.19 KB, patch)
2013-08-16 13:53 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2013-08-16 13:53:25 UTC
See patches
Comment 1 Colin Walters 2013-08-16 13:53:26 UTC
Created attachment 251845 [details] [review]
build: Don't install INSTALL

Really, no one needs this on their system in the first place.  But I'm
specifically deleting it because it broke in the gnome-ostree build
system; automake may have it be a symlink, and we don't want to
install that.
Comment 2 Colin Walters 2013-08-16 13:53:32 UTC
Created attachment 251846 [details] [review]
build: Fix srcdir != builddir

The enum files are potentially in $(builddir), not $(srcdir); we
should be able to just rely on Make's VPATH handling to DTRT.
Comment 3 Colin Walters 2013-08-16 13:53:35 UTC
Created attachment 251847 [details] [review]
build: Fix enum generation

First, drop the conditional on maintainer mode; we shouldn't rely on
--enable-maintainer-mode to build the enums from git.

Second, rework the style to fix srcdir != builddir, and avoid weird
hardcoded tempfile names.  This newer style can be found in the
gnome-shell git for example.
Comment 4 Debarshi Ray 2013-08-16 15:14:08 UTC
Comment on attachment 251845 [details] [review]
build: Don't install INSTALL

Thanks for the patch!
Comment 5 Debarshi Ray 2013-08-16 15:14:24 UTC
Comment on attachment 251846 [details] [review]
build: Fix srcdir != builddir

Thanks for the patch!
Comment 6 Debarshi Ray 2013-08-16 15:14:40 UTC
Comment on attachment 251847 [details] [review]
build: Fix enum generation

Thanks for the patch!