After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706124 - MetaWaylandSeat: don't use use events to count pressed buttons
MetaWaylandSeat: don't use use events to count pressed buttons
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-08-16 11:42 UTC by Giovanni Campagna
Modified: 2013-09-09 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaWaylandSeat: don't use use events to count pressed buttons (2.80 KB, patch)
2013-08-16 11:42 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-16 11:42:49 UTC 
Use the modifier mask instead, as events can get lost if there
is a clutter grab or if some other actor is capturing events.
Comment 1 Giovanni Campagna 2013-08-16 11:42:51 UTC 
Created attachment 251822 [details] [review]
MetaWaylandSeat: don't use use events to count pressed buttons
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-16 12:28:27 UTC 
Is there a reason we need to have accurate button_count when processing motion or keyboard or focus change events?
Comment 3 Giovanni Campagna 2013-08-16 14:19:55 UTC 
It's used by default_grab_focus to emulate the implicit pointer grab (which is part of the wayland protocol)
Comment 4 Giovanni Campagna 2013-09-09 11:41:33 UTC 
Any update on this?
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-09-09 15:53:43 UTC 
Review of attachment 251822 [details] [review]:

Looks good.

::: src/wayland/meta-wayland-seat.c
@@ +357,3 @@
     }
 
+  /* FIXME: synth a XI2 event and handle in display.c */

Yes, if you implement this, you need to fix it :)
Comment 6 Giovanni Campagna 2013-09-09 16:00:36 UTC 
Attachment 251822 [details] pushed as 28708e4 - MetaWaylandSeat: don't use use events to count pressed buttons