Created attachment 251732 [details] [review]
revert password generation to the password dialog

Created attachment 251733 [details] [review]
add password generation to the add user dialog

Created attachment 251952 [details] [review]
user-accounts: Add password generation back to the password dialog

Created attachment 251953 [details] [review]
user-accounts: add password generation to the add user dialog

Review of attachment 251733 [details] [review]:

::: panels/user-accounts/um-account-dialog.c
@@ -285,3 @@
-        if (strlen (verify) == 0) {
-                gtk_widget_set_sensitive (self->local_verify, strength_level > 0);
-        }

Again, removed this. I took it out in a previous patch. It made <TAB> key unusable in the dialog.

@@ +462,3 @@
 
+static void
+activate_icon (GtkEntry             *entry,

Fixed this function name.

Review of attachment 251732 [details] [review]:

Looks good with the change below.

::: panels/user-accounts/um-password-dialog.c
@@ -91,3 @@
-        if (strlen (verify) == 0) {
-                gtk_widget_set_sensitive (um->verify_entry, strength_level > 0);
-        }

Already removed this in another patch as it made <TAB> key unusable in the dialog, so removing here again.

@@ +421,3 @@
 
+static void
+activate_icon (GtkEntry             *entry,

Fixed this function name.

Attachment 251952 [details] pushed as a3d0840 - user-accounts: Add password generation back to the password dialog
Attachment 251953 [details] pushed as 60e1999 - user-accounts: add password generation to the add user dialog