After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706058 - Fall-back search in virtual containers causes recursion
Fall-back search in virtual containers causes recursion
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
0.19.x
Other Linux
: Normal critical
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-15 10:52 UTC by Jens Georg
Modified: 2013-08-20 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-export: Fix fall-back search recursion (4.38 KB, patch)
2013-08-17 07:38 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2013-08-15 10:52:19 UTC 
If search called on virtual containers hits an unimplemented column, it falls back to simple_search which calls get_children which calls search again.

Mainly happens with @refID searches now.
Comment 1 Jens Georg 2013-08-17 07:38:06 UTC 
Created attachment 251975 [details] [review]
media-export: Fix fall-back search recursion
Comment 2 Jens Georg 2013-08-18 05:35:40 UTC 
Review of attachment 251975 [details] [review]:

Needs small fix

::: src/plugins/media-export/rygel-media-export-query-container.vala
@@ +52,3 @@
+               expression == null ? "null" : expression.to_string (),
+               this.id);
+        // Override DBContainer search to always use fall-back search.

Stray debug
Comment 3 Jens Georg 2013-08-20 15:56:33 UTC 
Attachment 251975 [details] pushed as aa5e991 - media-export: Fix fall-back search recursion