Created attachment 251714 [details] [review]
keyboard: Change label to "keyboard layouts" rather than input sources

Review of attachment 251714 [details] [review]:

OK.

Thanks.

Pushed master: 8148937fa419d3d5bbfc81cf08a37ef14436aa52

Input sources is more than keyboard layouts - you can't simply substitute one string for another. Also, how will this match up with the control center?

Potential solutions could be to call it "Keyboards & Input Methods", or to have a substring with an explanation, such as "Select keyboards or other input methods".

Does anyone know how OS X does it, btw? They use "Input Sources" in their System Settings.

OSX:

"Select your keyboard" 
"Choose a keyboard layout"

http://youtu.be/irgiVzBwaos?t=7m

None of the 12 people we asked understood the phrase "input sources" in g-i-s, i'd suggest it was changed in g-c-c too.

I don't think we have any input sources which aren't keyboard at this point.

(In reply to comment #6)
> OSX:
> 
> "Select your keyboard" 
> "Choose a keyboard layout"
> 
> http://youtu.be/irgiVzBwaos?t=7m

Interesting. Is that literally asking for the layout of the keyboard, or does it allow input methods to be selected also?

> None of the 12 people we asked understood the phrase "input sources" in g-i-s,
> i'd suggest it was changed in g-c-c too.
> 
> I don't think we have any input sources which aren't keyboard at this point.

They all use the keyboard, but they are not all keyboard layouts.

I've added a mockup for input sources: https://raw.github.com/gnome-design-team/gnome-mockups/master/initial-setup/initial-setup-input-methods.png

This keeps the title but adds an explanation. It is also consistent with what I've been wanting for the control center (see .

As a side note, there's an outstanding request (bug 702349) to implement a redesigned input sources panel. It says: "There's no explanation of
what input sources are and a big empty list list with little controls at the
bottom. It is unclear whether it is necessary to interact with the page, and if
so how." I think that's basically what we're seeing here.

Also, as previously stated, I would prefer it if this panel didn't exist at all.

Created attachment 254261 [details] [review]
keyboard: Update descriptive label to be in line with design.

Review of attachment 254261 [details] [review]:

this would be a small improvement, but you need to ask for a string freeze break.

did you want to ask for a string freeze for this, Michael ?

(In reply to comment #10)
> did you want to ask for a string freeze for this, Michael ?

No, I wasn't sure how important it is, so I'll leave this up to.

I'd really like to resolve this. I think we can use "Typing" as the heading, and "Add keyboard layouts or other input methods" as a description string.

Created attachment 257553 [details] [review]
keyboard: Update descriptive label and titel to be in line with design.

Updated strings

Review of attachment 257553 [details] [review]:

looks good

pushed master b91ef2c0bfc2da430124b018d9059856b109b0b4