GNOME Bugzilla – Bug 706041
Fixes for the rfkill plugin
Last modified: 2013-08-16 17:38:00 UTC
Discovered in testing.
Created attachment 251673 [details] [review] rfkill: Account for having zero rfkill switches for airplane mode This is the case in desktops and VMs.
Created attachment 251675 [details] [review] rfkill: Add a new property to determine whether we can toggle airplane mode On some systems like desktops or VMs, we have no rfkill switches to toggle, so we shouldn't show any switches in the control center.
Review of attachment 251673 [details] [review]: Probably best to just commit the relevant change, and leave out the refactoring until Bastien comes back. ::: plugins/rfkill/gsd-rfkill-manager.c @@ +103,3 @@ + if (g_hash_table_size (manager->priv->killswitches) == 0) { + return FALSE; + } This is the relevant change @@ +117,1 @@ } This looks like an unrelated refactoring. No opinion on it.
Review of attachment 251675 [details] [review]: Looks fine to me.
Attachment 251673 [details] pushed as 6d5774b - rfkill: Account for having zero rfkill switches for airplane mode Attachment 251675 [details] pushed as 2c09798 - rfkill: Add a new property to determine whether we can toggle airplane mode