GNOME Bugzilla – Bug 706020
Finish geocode-glib 0.99.1 porting
Last modified: 2013-08-14 20:43:16 UTC
Additional changes seems to have happened to the gecode-glib 0.99.1 api between empathy was ported and geocode-glib released. Here are the remaining changes to let empathy build against the actually finished release of geocode-glib 0.99.1.
Created attachment 251648 [details] [review] Use new api-versioned name for geocode-glib geocode-glib has changed the name of the pkg-config file to include the api version. Update configure script accordingly. See: https://git.gnome.org/browse/geocode-glib/commit/?id=1cadaa879b7d72d973880680b5f947fd5c275974 "pkg-config: Version the pkg-config file"
Created attachment 251649 [details] [review] Update to new GeocodeLocation API in geocode-glib 0.99.1 Use new accessor functions. The location structure members has been hidden. Use regular g_object_unref, since the geocode_location_free has been removed. See: https://git.gnome.org/browse/geocode-glib/commit?id=5372f2f7ff97707dcc839bd3ed79ea9f289f7409 "lib: Turn GeocodeLocation into a proper GObject"
Review of attachment 251648 [details] [review]: Looks good
Review of attachment 251649 [details] [review]: Looks good but please try to change the commit log summary to fit 50 characters (Read under DISCUSSION in `git commit` manpage) before you push. Details is where you can insert as many details about the change as you want.
Pushed to master. https://git.gnome.org/browse/empathy/commit/?id=4682c05ce90708e89c8690d4fb395fcee73b9d71 https://git.gnome.org/browse/empathy/commit/?id=acaa1e4f9d2c5e746e895a7ca3e6002ac502cc2a PS. These commits should probably also go into the 3.8 branch (since porting started in 3.7 series already) in case there are any plans to do any more 3.8 releases.