GNOME Bugzilla – Bug 706009
Wrong text color for insensitive GtkLabels
Last modified: 2013-08-20 00:08:35 UTC
With gnome-themes-standard git master, insensitive GtkLabels aren't themed properly. gtk_widget_set_sensitive(label, FALSE) should turn the text gray, but it doesn't seem to affect the text color at all. This looks like a regression from https://git.gnome.org/browse/gnome-themes-standard/commit/?id=4d14019236d1131b9bc71a376306170f4bb15375 which started overriding insensitive GtkLabel background color.
Created attachment 251633 [details] [review] labels: properly set the insensitive color This fixes a fallout from commit 4d14019236d1131b9bc71a376306170f4bb15375 that started overriding the background-color property for insensitive labels without setting the text color.
Created attachment 252145 [details] screenshot before
I don't think this patch is correct - I believe this is a regression of the changes in state propagation that happened in GTK this cycle, and the theme didn't correctly adapt. I have a tentative alternative patch for this, will attach it here shortly.
Created attachment 252320 [details] [review] gtk3: fix propagation for insensitive colors Since 30609ba766dd055f41002dcb813225d619b1d951 we stopped using wildcard selectors to propagate insensitive state colors. Turns out that part of the commit was wrong, as typically the insensitive state is set on a widget down the hierarchy, and not the toplevel, so relying on inheritance from .background won't work. This commit partially reverts some of the changes from 30609ba766dd055f41002dcb813225d619b1d951 to make insensitive colors work correctly again. -- Kalev, can you check this patch fixes your issue as well? Thanks.
Review of attachment 252320 [details] [review]: I can confirm it fixes my issue. Thanks Cosimo!
Thanks, I pushed this to master now. Attachment 252320 [details] pushed as 5362ef1 - gtk3: fix propagation for insensitive colors