Created attachment 251506 [details] [review]
modalDialog: The dialog layout should expand, not the buttons

Created attachment 251507 [details] [review]
network: Add an empty state to the wifi dialog and adjust the sizing

Review of attachment 251506 [details] [review]:

So i think this is okay, provided everything still looks right after the change (please verify). By moving expand up, you're making all children implicitly expand I believe, so there is some potential for things to shift around.

::: js/ui/modalDialog.js
@@ +100,3 @@
                                 y_fill:  true,
                                 x_align: St.Align.MIDDLE,
                                 y_align: St.Align.START });

Do these aligns do anything since x_fill and y_fill are set?

(In reply to comment #3)
> Do these aligns do anything since x_fill and y_fill are set?

https://git.gnome.org/browse/gnome-shell/commit/?id=47b8d16067180cb5c7ad86efb99819ad466312a4

You tell me :)

Review of attachment 251507 [details] [review]:

looks okay. the theme commit should probably be separate, but whatever.

::: data/theme/gnome-shell.css
@@ +275,3 @@
+    max-height: 500px;
+    min-height: 450px;
+    min-width: 470px;

given hidpi screens are on the horizon and the dialog contains a lot of text, maybe it should be sized in ems?

::: js/ui/status/network.js
@@ +634,3 @@
         this._scrollView = new St.ScrollView({ style_class: 'nm-dialog-scroll-view' });
+        this._scrollView.set_x_expand(true);
+        this._scrollView.set_y_expand(true);

Is there a reason these aren't getting passed at construction time above? no big deal, I guess, but throwing them in the curly braces might look a little nicer.

@@ +646,3 @@
+        this._stack.add_child(this._noNetworksLabel);
+
+        this.contentLayout.add(this._stack, { expand: true });

do you need this { expand: true }?

Attachment 251506 [details] pushed as 3bb330f - modalDialog: The dialog layout should expand, not the buttons
Attachment 251507 [details] pushed as 362e0bf - network: Add an empty state to the wifi dialog and adjust the sizing