GNOME Bugzilla – Bug 705898
Fix the app menu button
Last modified: 2013-08-13 15:22:41 UTC
The code is just broken. See patches.
Created attachment 251463 [details] [review] panel: Rewrite the app menu to use the new "sync" pattern The existing app menu was a kludge of legacy code that tried to manage a bunch of state, and had a number of issues: * It didn't properly manage visibility when combined with multiple apps and the overview. * It didn't properly manage reactivity when tabbing away from a busy app to another app. * It didn't properly disconnect signals when going from one app to nothing. and countless others. Rewrite it to use the new "sync" code pattern, where we centralize all state management and do transitions from that, rather than strange and quirky control flow.
Created attachment 251464 [details] [review] panelMenu: Use the accessible-name property instead of a label actor We already have code for this in StWidget.
Review of attachment 251463 [details] [review]: Does this work with keynav to the app menu (where the focus is on the stage but we keep the previous app menu visible?) It doesn't seem to me...
Created attachment 251487 [details] [review] panelMenu: Use the accessible-name property instead of a label actor We already have code for this in StWidget.
Created attachment 251488 [details] [review] panel: Rewrite the app menu to use the new "sync" pattern The existing app menu was a kludge of legacy code that tried to manage a bunch of state, and had a number of issues: * It didn't properly manage visibility when combined with multiple apps and the overview. * It didn't properly manage reactivity when tabbing away from a busy app to another app. * It didn't properly disconnect signals when going from one app to nothing. and countless others. Rewrite it to use the new "sync" code pattern, where we centralize all state management and do transitions from that, rather than strange and quirky control flow.
No, Ctrl+Alt+Tab works for me here, but I did find a bug where moving a window to a different workspace with Ctrl+Alt+Shift+Down made the app menu disappear. Can you try with this patch set? Order has been reversed intentionally.
Attachment 251487 [details] pushed as 33e51cc - panelMenu: Use the accessible-name property instead of a label actor Attachment 251488 [details] pushed as 7563e04 - panel: Rewrite the app menu to use the new "sync" pattern Reviewed on IRC.