After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705872 - Make headerbar as titlebar and add close button
Make headerbar as titlebar and add close button
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-12 21:18 UTC by Yosef Or Boczko
Modified: 2013-08-13 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make headerbar as titlebar and add close button (1.95 KB, patch)
2013-08-12 21:19 UTC, Yosef Or Boczko 		committed Details | Review
Bump GTK requirement (708 bytes, patch)
2013-08-13 01:38 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-08-12 21:18:55 UTC 
This need be to 3.10.
Comment 1 Yosef Or Boczko 2013-08-12 21:19:47 UTC 
Created attachment 251425 [details] [review]
Make headerbar as titlebar and add close button
Comment 2 Yosef Or Boczko 2013-08-13 01:38:15 UTC 
Created attachment 251436 [details] [review]
Bump GTK requirement
Comment 3 Cosimo Cecchi 2013-08-13 10:25:05 UTC 
Review of attachment 251425 [details] [review]:

Looks good
Comment 4 Cosimo Cecchi 2013-08-13 10:25:21 UTC 
Review of attachment 251436 [details] [review]:

Sure
Comment 5 Yosef Or Boczko 2013-08-13 10:30:56 UTC 
Review of attachment 251425 [details] [review]:

pushed as 836e7309fd3327c6079f0cd134454a890207cf48 - Make headerbar as titlebar and add close button
Comment 6 Yosef Or Boczko 2013-08-13 10:31:22 UTC 
Review of attachment 251436 [details] [review]:

pushed as ffcd9deed0e50a751726a3cbea9b3c20df54ed89 - Bump GTK requirement