After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705871 - Fix time representation in RTL languages in dialog new alarm
Fix time representation in RTL languages in dialog new alarm
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-12 20:51 UTC by Yosef Or Boczko
Modified: 2013-08-13 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix time representation in RTL languages in dialog new alarm (1.31 KB, patch)
2013-08-12 20:52 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2013-08-12 20:51:35 UTC
Is fix the time representation in RTL languages *** in dialog new alarm ***.
I use in direction of GtkWidget.
Comment 1 Yosef Or Boczko 2013-08-12 20:52:42 UTC
Created attachment 251424 [details] [review]
Fix time representation in RTL languages in dialog new alarm
Comment 2 Evgeny Bobkin 2013-08-13 17:37:38 UTC
Review of attachment 251424 [details] [review]:

I believe this should be done in glade, instead.
Comment 3 Evgeny Bobkin 2013-08-13 17:39:01 UTC
Thank you for spotting this one.
Comment 4 Yosef Or Boczko 2013-08-13 17:42:03 UTC
(In reply to comment #2)
> Review of attachment 251424 [details] [review]:
> 
> I believe this should be done in glade, instead.

No property of direction in GtkWidget.
Have just functions for this (gtk_widget_get_direction,
gtk_widget_set_default_direction and gtk_widget_get_default_direction).

So, Impossible to be this in glade.
This must be in the code.
Comment 5 Evgeny Bobkin 2013-08-13 17:50:01 UTC
Review of attachment 251424 [details] [review]:

then looks good.
Comment 6 Yosef Or Boczko 2013-08-13 17:53:25 UTC
Review of attachment 251424 [details] [review]:

pushed as ace8875e686491b34a42f05b182d05a7ef604676 - Fix time representation in RTL languages in dialog new alarm