After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705862 - MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon
MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-08-12 16:26 UTC by Giovanni Campagna
Modified: 2013-08-30 08:39 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon (11.88 KB, patch)
2013-08-12 16:26 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-12 16:26:30 UTC 
We need to track the full xkb_state to have the necessary information
to send to the clients, otherwise they may get confused and lock
or invert the modifiers. In the evdev backend, we just retrieve the
same state object that clutter is using, while in the other backends
we fake the state using what clutter is providing (which is a subset
of what X11 provides, which would be necessary to have full state)
Comment 1 Giovanni Campagna 2013-08-12 16:26:32 UTC 
Created attachment 251392 [details] [review]
MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon
Comment 2 Matthias Clasen 2013-08-18 19:40:42 UTC 
since the clutter patches have landed, I guess this is ripe for review now
Comment 3 Giovanni Campagna 2013-08-28 15:27:10 UTC 
Yes, this would be very much needed for 3.10, otherwise keyboard input can be very funny.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-28 15:41:26 UTC 
Review of attachment 251392 [details] [review]:

OK.
Comment 5 Giovanni Campagna 2013-08-28 15:46:03 UTC 
Attachment 251392 [details] pushed as 519a06b - MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon
Comment 6 Giovanni Campagna 2013-08-28 16:05:01 UTC 
Had to revert, this depends on the bare metal work, otherwise it won't build.
Comment 7 Giovanni Campagna 2013-08-30 08:38:57 UTC 
Attachment 251392 [details] pushed as 59b274f - MetaWaylandKeyboard: use the new clutter-evdev support for xkbcommon