After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705852 - Now playing indicator is lost on switching views / artists / artist albums
Now playing indicator is lost on switching views / artists / artist albums
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
available
Depends on:
Blocks:
 
 
Reported: 2013-08-12 15:21 UTC by Vadim Rutkovsky
Modified: 2015-03-01 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
widgets: Use artist name as playlist id for Artists view (1.73 KB, patch)
2014-04-09 08:51 UTC, Arnel Borja
committed Details | Review
view: Reshow albums widget of artist if running playlist (4.47 KB, patch)
2014-04-09 08:52 UTC, Arnel Borja
committed Details | Review

Description Vadim Rutkovsky 2013-08-12 15:21:10 UTC
STR:

 * Switch to Artists view
 * Select "Artist1"
 * Click on "Track1" to start playback
 * Select "Artists2"
 * Select "Artist1"
Then Now playing indicator is showing that "Track1" is being played

Actual result: now playing indicator is not set
Comment 1 Arnel Borja 2014-04-09 08:51:16 UTC
Created attachment 273868 [details] [review]
widgets: Use artist name as playlist id for Artists view

This allows the Artists view to easily lookup if the running playlist is
from itself.
Comment 2 Arnel Borja 2014-04-09 08:52:13 UTC
Created attachment 273869 [details] [review]
view: Reshow albums widget of artist if running playlist

In Artists view, reshow the widget for the albums of the artist if
available and it is the running playlist. If it is not the running
playlist, destroy it before creating a new one.
Comment 5 Vadim Rutkovsky 2014-04-09 11:18:27 UTC
Several other issues with now plying indicator remain:
1) * Select a track on Artists/Playlist/Songs view
   * Select a track on different view
   * Return to a previous view
   Result: view is not refreshed, when user hovers mouse on now playing indicator it dissapears
   We should refresh the view on switching, but simple view.queue_draw doesn't seem to help

2) * Select an artist with 2+ albums
   * Select a track from first album
   * Switch to Songs view
   * Return to artists view
   * Select a track from second album
   Result: artists view displays two tracks as being played now

   update_model on artists view should cleanup indicators from all album widgets for selected artist
Comment 6 Vadim Rutkovsky 2014-04-23 09:55:29 UTC
(In reply to comment #5)
'Select' == 'play the track' there, sorry for confusion

> 2) * Select an artist with 2+ albums
>    * Select a track from first album
>    * Switch to Songs view
missed the step here:
     * Play the track on Songs view
Comment 7 Vadim Rutkovsky 2015-03-01 14:49:58 UTC
Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=a6ff4d6