GNOME Bugzilla – Bug 705668
Some labels does not update correctly when changing account's identifier
Last modified: 2013-08-09 08:57:05 UTC
empathy-accounts let the user change existing account's identifier. That's questionable feature, but the UI should update correctly if the user does that. Currently the account's display name is not changed in the GtkInfoBar, and the identifier/alias is not changed in the account settings.
Created attachment 251155 [details] [review] EmpathyUserInfo: Update identifier/alias when they change on the account When the account goes online the account's nickname quickly changes from the identifier to the actual nickname from the self VCard. Identifier can change as well when editing account settings.
Created attachment 251188 [details] [review] EmpathyAccountSettings: remember the new account display name when setting one.
Created attachment 251189 [details] [review] EmpathyAccountsDialog: Simplify the way we update account display name label in infobar accounts_dialog_update_status_infobar() is the function responsible for doing all updates.
Note that the 3rd commit is not strictly needed to fix this bug. That's actually how I initially fixed the bug because it takes the display-name from the TpAccount instead of from EmpathyAccountSettings. But I think settings needs to know the new display name as well.
Review of attachment 251155 [details] [review]: Looks good to me
Review of attachment 251188 [details] [review]: ++
Review of attachment 251189 [details] [review]: ++
Thanks, pushed to master.