After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705620 - Untranslatable string in new-location-dialog.ui
Untranslatable string in new-location-dialog.ui
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
3.9.x
Other All
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-07 15:56 UTC by Jiro Matsuzawa
Modified: 2013-08-08 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the value of the attribute (979 bytes, patch)
2013-08-07 16:01 UTC, Jiro Matsuzawa 		committed Details | Review

Description Jiro Matsuzawa 2013-08-07 15:56:40 UTC 
The title of the New Loation dialog is not translatable. I think the value of its translatable attribute is invalid. Look at the following patch:

$ git diff data/new-location-dialog.ui
diff --git a/data/new-location-dialog.ui b/data/new-location-dialog.ui
index 5872c8c..ae3946e 100644
--- a/data/new-location-dialog.ui
+++ b/data/new-location-dialog.ui
@@ -7,7 +7,7 @@
     <property name="modal">True</property>
     <property name="type_hint">dialog</property>
     <property name="transient-for">parent-window</property>
-    <property name="title" translatable="True">New Location</property>
+    <property name="title" translatable="yes">New Location</property>
     <child internal-child="vbox">
       <object class="GtkBox" id="dialog-vbox1">
         <property name="can_focus">False</property>
Comment 1 Jiro Matsuzawa 2013-08-07 16:01:03 UTC 
Created attachment 251085 [details] [review]
Fix the value of the attribute

Could you please review it.
Comment 2 André Klapper 2013-08-08 06:26:51 UTC 
Comment on attachment 251085 [details] [review]
Fix the value of the attribute

I'm bold and say "Please commit!" because it's correct and a simple patch.