After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705565 - matroskademux: add missing parsed field in mpeg audio caps
matroskademux: add missing parsed field in mpeg audio caps
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.1.3
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-06 13:43 UTC by Arnaud Vrac
Modified: 2013-08-12 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add missing parsed field in mpeg audio caps (1.02 KB, patch)
2013-08-06 13:43 UTC, Arnaud Vrac
rejected Details | Review

Description Arnaud Vrac 2013-08-06 13:43:42 UTC
Created attachment 250968 [details] [review]
add missing parsed field in mpeg audio caps

Pretty straightforward. This change is needed since the caps subset check were tightened to avoid plugging in a mpegaudioparse after matroskademux.
Comment 1 Sebastian Dröge (slomo) 2013-08-08 10:15:53 UTC
There's nothing in the Matroska spec that requires MPEG audio frames to be properly framed. You could have partial frames in a Matroska EBML element.

Also decodebin will *always* plug parsers now, even if you set parsed=true on the caps.
Comment 2 Arnaud Vrac 2013-08-08 11:36:18 UTC
(In reply to comment #1)
> There's nothing in the Matroska spec that requires MPEG audio frames to be
> properly framed. You could have partial frames in a Matroska EBML element.
> 

Ok, I wasn't sure about this.

> Also decodebin will *always* plug parsers now, even if you set parsed=true on
> the caps.

Not when the audio sink can also decode, which is my case
Comment 3 Sebastian Dröge (slomo) 2013-08-12 09:44:44 UTC
(In reply to comment #2)

> > Also decodebin will *always* plug parsers now, even if you set parsed=true on
> > the caps.
> 
> Not when the audio sink can also decode, which is my case

Well, if your audiosink accepts unparsed caps, decodebin won't plug a parser. That's true :)