After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705553 - rtph264pay: Entries of SPS and PPS duplicated
rtph264pay: Entries of SPS and PPS duplicated
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other All
: Normal normal
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-06 10:52 UTC by Morgan Lindqvist
Modified: 2013-08-13 14:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtph264depay: Make the SPS/PPS deduplication function generic (6.45 KB, patch)
2013-08-12 19:34 UTC, Olivier Crête 		committed Details | Review
rtph264pay: Use the SPS/PPS handling function from the depayloader (12.04 KB, patch)
2013-08-12 19:34 UTC, Olivier Crête 		committed Details | Review

Description Morgan Lindqvist 2013-08-06 10:52:53 UTC 
The function add_sps_pps_without_duplicates() in gstrtph264pay.c actually duplicates entries of SPS and PPS if they have the same id but different content.

The function gst_rtp_h264_add_sps_pps() in gstrtph264depay.c does this in a way that no duplicates are created.
Comment 1 Sebastian Dröge (slomo) 2013-08-08 10:03:59 UTC 
Do you want to provide a patch that fixes this?
Comment 2 Morgan Lindqvist 2013-08-08 10:47:42 UTC 
I do not have the possibility to provide a patch
Comment 3 Olivier Crête 2013-08-12 19:34:17 UTC 
Created attachment 251418 [details] [review]
rtph264depay: Make the SPS/PPS deduplication function generic

Alright, here are patches to use the working function in both, also deletes quite some duplicated code
Comment 4 Olivier Crête 2013-08-12 19:34:22 UTC 
Created attachment 251419 [details] [review]
rtph264pay: Use the SPS/PPS handling function from the depayloader

Remove duplicated copies
Comment 5 Olivier Crête 2013-08-13 14:39:28 UTC 
Fixed

commit 4c6e636720c4e054e958a7c6bdc42bdc315ed1b9
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Mon Aug 12 15:28:34 2013 -0400

    rtph264pay: Use the SPS/PPS handling function from the depayloader
    
    Remove duplicated copies
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705553

commit 742b90747da5f2f9bd1efd8ccc83e32a3a8fe2e1
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Mon Aug 12 15:26:08 2013 -0400

    rtph264depay: Make the SPS/PPS deduplication function generic
    
    Make it not touch any internals of the depayloader
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705553