GNOME Bugzilla – Bug 705537
Move to client side decoration
Last modified: 2013-08-07 16:01:51 UTC
Let's move to client side decorations as that seems to be the designers long term goal anyway.
Created attachment 250911 [details] [review] Add missing xml-declaration Add missing xml-declaration to app-menu.ui. This is supposed to start all xml files plus it makes emacs nxml-mode happy.
Created attachment 250912 [details] [review] Reindent xml Reindent main-window.ui to follow the rest of our xml.
Created attachment 250913 [details] [review] MainWindow: move to CSD Move maps to be client side decorated instead of relying on the window manager doing that. This move has been made by a few other apps in GNOME already (like devhelp) and is a goal for the future.
Review of attachment 250911 [details] [review]: ACK
Review of attachment 250912 [details] [review]: Kudos for doing this :)
Review of attachment 250913 [details] [review]: Its not very obvious from the .ui file changes, what exactly is happening. If you could summarize (preferably in commit log) what exactly are you changing to achieve the goal, would be nice. Also what is 'CSD'?
Created attachment 250973 [details] [review] MainWindow: move to CSD Move maps to be client side decorated (CSD), that is: Gtk+ will draw the window decorations instead of relying on the window manager for drawing them. This move has been made by a few other apps in GNOME already (like devhelp) and is mandatory for making us work in the wayland tech demo that will be released in 3.10. This is done by just moving the GdHeaderBar inside a special child to window with the attribute type = titlebar and that will be your new title bar.
Attachment 250911 [details] pushed as 89865d1 - Add missing xml-declaration Attachment 250912 [details] pushed as 4c5cd5e - Reindent xml
Created attachment 250988 [details] [review] MainWindow: move to CSD Move maps to be client side decorated (CSD), that is: Gtk+ will draw the window decorations instead of relying on the window manager for drawing them. This move has been made by a few other apps in GNOME already (like devhelp) and is mandatory for making us work in the wayland tech demo that will be released in 3.10. This is done by just moving the GdHeaderBar inside a special child to window with the attribute type = titlebar and that will be your new title bar.
Review of attachment 250988 [details] [review]: Thanks. Could also also add to log that you are adding a 'close' button.
Created attachment 250989 [details] [review] MainWindow: move to CSD Move maps to be client side decorated (CSD), that is: Gtk+ will draw the window decorations instead of relying on the window manager for drawing them. This move has been made by a few other apps in GNOME already (like devhelp) and is mandatory for making us work in the wayland tech demo that will be released in 3.10. This is done by just moving the GdHeaderBar inside a special child to window with the attribute type = titlebar and that will be your new title bar. I also added a close button like the other apps do, which will help people close the app even when maximised.
Review of attachment 250989 [details] [review]: Dude, you only changed the comment in the bz, not the commit log :)
Created attachment 251004 [details] [review] MainWindow: move to CSD Move maps to be client side decorated (CSD), that is: Gtk+ will draw the window decorations instead of relying on the window manager for drawing them. This move has been made by a few other apps in GNOME already (like devhelp) and is mandatory for making us work in the wayland tech demo that will be released in 3.10. This is done by just moving the GdHeaderBar inside a special child to window with the attribute type = titlebar and that will be your new title bar. I also added a close button like the other apps do, which will help people close the app even when maximised.
Attachment 251004 [details] pushed as 912c9f1 - MainWindow: move to CSD
Sorry for reopening but I am too lazy to open a new bug :) You can now remove the custom close button and use the new property they just added in these days show-close-button from the GtkHeaderBar.
(In reply to comment #15) > Sorry for reopening but I am too lazy to open a new bug :) > You can now remove the custom close button and use the new property they just > added in these days show-close-button from the GtkHeaderBar. This has been fixed as part of bug#705594.