After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705536 - Make geocode-glib work for Geoclue
Make geocode-glib work for Geoclue
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-05 23:51 UTC by Zeeshan Ali
Modified: 2013-08-06 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ipclient: Make use of g_clear_pointer() (983 bytes, patch)
2013-08-05 23:52 UTC, Zeeshan Ali 		rejected Details | Review
ipclient: Use libsoup directly (6.12 KB, patch)
2013-08-05 23:52 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2013-08-05 23:51:59 UTC 
Geoclue needs to be running out to the session and hence can't access HTTP through gvfs. Attaching patches that allow Geoclue to run on system bus as root.
Comment 1 Zeeshan Ali 2013-08-05 23:52:01 UTC 
Created attachment 250909 [details] [review]
ipclient: Make use of g_clear_pointer()
Comment 2 Zeeshan Ali 2013-08-05 23:52:11 UTC 
Created attachment 250910 [details] [review]
ipclient: Use libsoup directly

While rest of the code was ported to use libsoup directly, ipclient was
still using gio/gvfs for HTTP, which is not going to work for an app
that runs out of the session: Geoclue.
Comment 3 Bastien Nocera 2013-08-06 09:56:49 UTC 
Review of attachment 250909 [details] [review]:

Rejected. Makes no sense in finalize. We don't need the pointers zero'ed (they're not going to be used again), and g_free() can take NULL pointers.
Comment 4 Bastien Nocera 2013-08-06 09:58:20 UTC 
Review of attachment 250910 [details] [review]:

Looks fine.
Comment 5 Zeeshan Ali 2013-08-06 10:13:34 UTC 
Attachment 250910 [details] pushed as 761df0c - ipclient: Use libsoup directly