After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705529 - GtkTextView: improve documentation
GtkTextView: improve documentation
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
3.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-05 18:53 UTC by Sébastien Wilmet
Modified: 2013-08-06 10:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improve doc of gtk_text_tag_table_remove() (1.22 KB, patch)
2013-08-05 18:53 UTC, Sébastien Wilmet
needs-work Details | Review
Improve doc of gtk_text_tag_table_remove() (1.20 KB, patch)
2013-08-05 21:05 UTC, Sébastien Wilmet
accepted-commit_now Details | Review

Description Sébastien Wilmet 2013-08-05 18:53:17 UTC
A patch will be attached.
Comment 1 Sébastien Wilmet 2013-08-05 18:53:48 UTC
Created attachment 250898 [details] [review]
Improve doc of gtk_text_tag_table_remove()

It's obvious, but it's better to say it.
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-08-05 19:50:23 UTC
Review of attachment 250898 [details] [review]:

See comments.

::: gtk/gtktexttagtable.c
@@ +313,3 @@
+ *
+ * Remove a tag from the table. The tag is also removed from the
+ * #GtkTextBuffer<!-- -->s that have @table as their tag table. The table's

that has @table as its tag table. <- I think it is more correct like that

@@ +314,3 @@
+ * Remove a tag from the table. The tag is also removed from the
+ * #GtkTextBuffer<!-- -->s that have @table as their tag table. The table's
+ * reference to the tag is removed, so be careful - the tag will end up

don't use -, instead use a dot?
Comment 3 Sébastien Wilmet 2013-08-05 21:04:51 UTC
(In reply to comment #2)
> don't use -, instead use a dot?

It was already present, but sure, I can change it.
Comment 4 Sébastien Wilmet 2013-08-05 21:05:11 UTC
Created attachment 250901 [details] [review]
Improve doc of gtk_text_tag_table_remove()

It's obvious, but it's better to say it.
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-08-06 06:05:47 UTC
Review of attachment 250901 [details] [review]:

Looks good.
Comment 6 Sébastien Wilmet 2013-08-06 10:14:58 UTC
Commit pushed.