GNOME Bugzilla – Bug 705456
Uniformize usage of gsettings key
Last modified: 2013-08-05 21:25:50 UTC
Currently gsettings key are mostly referred to by writing directly the corresponding name, i.e. g_settings_get (settings, "key-name"); while four of them are defined in settings-key.{h,cpp} for no apparent reason (solaris_mode, draw_stacked, open_files_tree_prefix, network_in_bits). I'd say, all keys should be treated on an equal footing. The simplest thing is drop settings-key.* and just use "key-name" for all of them. Alternatively, if we want to keep symbolic names (which could be a good idea since we would get compiler errors on typos), then I'd prefer just going with simple macros like #define GSM_SETTING_CURRENT_TAB "current-tab" What do you think?
I have also seen that settings-key.{cpp,h} might need either dropping or updating, but dropping sounds better, and use #define instead. So we should go for that.
Created attachment 250842 [details] [review] Consistently use #defines to identify gsettings keys
Attachment 250842 [details] pushed as b4f345c - Consistently use #defines to identify gsettings keys