After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705455 - po/Makefile.in.in should not be customized
po/Makefile.in.in should not be customized
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
unspecified
Other Mac OS
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-04 16:22 UTC by Jeremy Huddleston
Modified: 2013-12-22 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
po.patch (4.66 KB, patch)
2013-08-04 16:22 UTC, Jeremy Huddleston 		none Details | Review
Generate Makevars with the right GETTEXT_PACKAGE name (1.73 KB, patch)
2013-12-06 19:54 UTC, Olivier Crête 		rejected Details | Review

Description Jeremy Huddleston 2013-08-04 16:22:54 UTC 
Created attachment 250811 [details] [review]
po.patch

po/Makefile.in.in is replaced whenever one autoreconfs

The only difference is the addition of:
GETTEXT_PACKAGE = @GETTEXT_PACKAGE@

You should not do this in a file that will get replaced automatically with autoreconfing.

Instead, place this inside of your Makevars which isn't clobbered on autoreconf.  You should rename Makevars to Makevars.in, add that line, and then add po/Makevars to configure.ac's list of files to generate.

Patch is provided
Comment 1 Tim-Philipp Müller 2013-08-05 11:25:03 UTC 
Great, thanks for that, finally we can get rid of that ugly hack.
Comment 2 Olivier Crête 2013-12-06 19:54:03 UTC 
Created attachment 263693 [details] [review]
Generate Makevars with the right GETTEXT_PACKAGE name

Just to confirm, this is the patch we want to apply ?
Comment 3 Sebastian Dröge (slomo) 2013-12-14 18:25:31 UTC 
Yes, but it breaks "make distcheck". I have a fix
Comment 4 Sebastian Dröge (slomo) 2013-12-14 18:32:49 UTC 
Or maybe not. What needs to be done is that Makevars.in is shipped (DISTFILES += Makevars.in in Makevars.in). And also Makevars should not be shipped, and cleaned by "make distclean". However the "make distclean" part does not seem to be possible with the Makefiles generated by autopoint.
Comment 5 Tim-Philipp Müller 2013-12-22 23:22:12 UTC 
Fixed this differently now, by just setting domain explicitly in po/Makevars without generating the file from the stuff in configure.ac. Not ideal, but seems like the least worst option to me.