After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705439 - dlna-renderer: Avoid async loading of PushHost and Player proxies
dlna-renderer: Avoid async loading of PushHost and Player proxies
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on: 705433
Blocks:
 
 
Reported: 2013-08-04 09:39 UTC by Emanuele Aina
Modified: 2013-08-06 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dlna-renderer: Avoid async loading of PushHost and Player proxies (8.05 KB, patch)
2013-08-04 09:39 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-08-04 09:39:17 UTC 
Since at the moment we don't really mind about properties and signals on
the PushHost and Player interfaces, we can rely on the fact that
g_dbus_proxy_new_sync() is guaranteed to never block if the
G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES and
G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS are specified and severely
simplify a lot of code since we're left with just one async task.

This uses the RETURN_ON_ERROR() macro from bug #705433.
Comment 1 Emanuele Aina 2013-08-04 09:39:20 UTC 
Created attachment 250793 [details] [review]
dlna-renderer: Avoid async loading of PushHost and Player proxies

Since at the moment we don't really mind about properties and signals on
the PushHost and Player interfaces, we can rely on the fact that
g_dbus_proxy_new_sync() is guaranteed to never block if the
G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES and
G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS are specified and severely
simplify a lot of code since we're left with just one async task.
Comment 2 Debarshi Ray 2013-08-06 16:32:49 UTC 
Review of attachment 250793 [details] [review]:

Looks good! Thanks for the patch.