GNOME Bugzilla – Bug 705352
Add more actions to standard error page
Last modified: 2018-08-03 19:59:15 UTC
Created attachment 250702 [details] [review] Add new home/back buttons to standard error page On the current error page that is displayed on any of the different possible problem types a button to "Try Again" is shown. Apart from this button, it could make sense to add actions to navigate back, or go to the starting point (being it either the overview or the homepage, if it has been configured). This makes that error page more useful, and even more when for any reason the user is browsing explicitly fullscreen or only that mode available.
Review of attachment 250702 [details] [review]: LGTM in general, just some minor nits. I've fixed them and applied the patch in kiosk-mode branch. Anyway we need a rebased patch for master. ::: embed/ephy-web-view.c @@ +2458,3 @@ + home_address = g_settings_get_string (EPHY_SETTINGS_MAIN, EPHY_PREFS_HOMEPAGE_URL); + if (home_address == NULL || home_address[0] == '\0') You should free home_address here before setting a new value as it could be empty. @@ +2459,3 @@ + home_address = g_settings_get_string (EPHY_SETTINGS_MAIN, EPHY_PREFS_HOMEPAGE_URL); + if (home_address == NULL || home_address[0] == '\0') + home_address = g_strdup("ephy-about:overview"); Missing space before "(". @@ +2462,3 @@ + + button_home = g_strdup_printf ("<button onclick=\"javascript:go_home()\">%s</button>", + _("Go home")); Don't use tabs to indent in this file. @@ +2465,3 @@ + + button_reload = g_strdup_printf ("<button onclick=\"javascript:load_anyway()\">%s</button>", + Ditto. @@ +2469,3 @@ + if (!g_settings_get_boolean (EPHY_SETTINGS_LOCKDOWN, EPHY_PREFS_LOCKDOWN_HISTORY)) + button_back = g_strdup_printf ("<button onclick=\"javascript:go_back()\">%s</button>", + _("Go home")); Ditto. @@ +2513,3 @@ "<strong>%s</strong> developers.</p>"), LSB_DISTRIBUTOR); + Unneeded extra line.
To upstream this, the new buttons should be conditional on some hidden setting, since they're only wanted in kiosk mode.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/201.