GNOME Bugzilla – Bug 705322
automatic login switch is enabled by default
Last modified: 2013-08-02 16:42:04 UTC
it should be disabled and only be enabled when user has permission, just like other controls
Created attachment 250665 [details] [review] proposed patch
Review of attachment 250665 [details] [review]: Functions show_user and on_permissions_changed are closely connected. I think we should to call on_permissions_changed always after show_user call to make sure everything has correct sensitivity and shouldn't to check permissions in show_user. Maybe autologin switch isn't only problematic occurrence...
Created attachment 250698 [details] [review] proposed patch, v2
Review of attachment 250698 [details] [review]: ::: panels/user-accounts/um-user-panel.c @@ +334,3 @@ show_user (user, d); + if (d->permission != NULL) + on_permission_changed (d->permission, NULL, d); The only other place show_user is called also calls on_permission_changed after checking d->permission in exactly the same way, so it may be worth just doing this at the end of show_user instead.
Created attachment 250725 [details] [review] proposed patch, v3
Review of attachment 250725 [details] [review]: Looks fine, please commit to master and gnome-3-8 branches.
pushed, thanks.