After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705322 - automatic login switch is enabled by default
automatic login switch is enabled by default
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other All
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-02 00:38 UTC by Jonh Wendell
Modified: 2013-08-02 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.37 KB, patch)
2013-08-02 00:40 UTC, Jonh Wendell
needs-work Details | Review
proposed patch, v2 (1.81 KB, patch)
2013-08-02 12:50 UTC, Jonh Wendell
reviewed Details | Review
proposed patch, v3 (2.08 KB, patch)
2013-08-02 16:32 UTC, Jonh Wendell
committed Details | Review

Description Jonh Wendell 2013-08-02 00:38:52 UTC
it should be disabled and only be enabled when user has permission, just like other controls
Comment 1 Jonh Wendell 2013-08-02 00:40:05 UTC
Created attachment 250665 [details] [review]
proposed patch
Comment 2 Ondrej Holy 2013-08-02 11:19:19 UTC
Review of attachment 250665 [details] [review]:

Functions show_user and on_permissions_changed are closely connected. I think we should to call on_permissions_changed always after show_user call to make sure everything has correct sensitivity and shouldn't to check permissions in show_user. Maybe autologin switch isn't only problematic occurrence...
Comment 3 Jonh Wendell 2013-08-02 12:50:13 UTC
Created attachment 250698 [details] [review]
proposed patch, v2
Comment 4 Thomas Wood 2013-08-02 16:04:51 UTC
Review of attachment 250698 [details] [review]:

::: panels/user-accounts/um-user-panel.c
@@ +334,3 @@
                         show_user (user, d);
+                        if (d->permission != NULL)
+                                on_permission_changed (d->permission, NULL, d);

The only other place show_user is called also calls on_permission_changed after checking d->permission in exactly the same way, so it may be worth just doing this at the end of show_user instead.
Comment 5 Jonh Wendell 2013-08-02 16:32:56 UTC
Created attachment 250725 [details] [review]
proposed patch, v3
Comment 6 Thomas Wood 2013-08-02 16:35:14 UTC
Review of attachment 250725 [details] [review]:

Looks fine, please commit to master and gnome-3-8 branches.
Comment 7 Jonh Wendell 2013-08-02 16:41:51 UTC
pushed, thanks.