After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705320 - gtkicontheme: check for GdkPixbuf first
gtkicontheme: check for GdkPixbuf first
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 705321 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-01 21:11 UTC by Allison Karlitskaya (desrt)
Modified: 2013-08-02 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkicontheme: check for GdkPixbuf first (3.05 KB, patch)
2013-08-01 21:11 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-08-01 21:11:52 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-08-01 21:11:54 UTC 
Created attachment 250661 [details] [review]
gtkicontheme: check for GdkPixbuf first

We checked for G_IS_LOADABLE_ICON() before GDK_IS_PIXBUF().

Since we made GdkPixbuf implement GLoadableIcon, the special case for
pixbufs is never used, and the much much slower GLoadableIcon path is
taken instead.  Move the GdkPixbuf one to be first to fix that.
Comment 2 fakey 2013-08-01 21:33:58 UTC 
*** Bug 705321 has been marked as a duplicate of this bug. ***
Comment 3 fakey 2013-08-01 21:46:27 UTC 
Review of attachment 250661 [details] [review]:

Looks good, tested and it fixes the issue.
Comment 4 Allison Karlitskaya (desrt) 2013-08-02 13:00:28 UTC 
Attachment 250661 [details] pushed as 03147b0 - gtkicontheme: check for GdkPixbuf first
Comment 5 Allison Karlitskaya (desrt) 2013-08-02 13:11:30 UTC 
Backported to 3.8 too, so Ubuntu can grab it from there.