After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705305 - Fix time representation in RTL languages in the timer
Fix time representation in RTL languages in the timer
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-01 16:34 UTC by Yosef Or Boczko
Modified: 2013-08-12 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screencast - time in Hebrew (RTL) language (843.20 KB, video/ogg)
2013-08-01 16:36 UTC, Yosef Or Boczko 		  Details
Fix time representation in RTL languages in the timer (2.06 KB, patch)
2013-08-01 16:36 UTC, Yosef Or Boczko 		none Details | Review
patch proposal (2.46 KB, patch)
2013-08-12 06:50 UTC, Evgeny Bobkin 		none Details | Review
patch proposal (2.44 KB, patch)
2013-08-12 07:04 UTC, Evgeny Bobkin 		committed Details | Review
patch proposal for stopwatch (2.97 KB, patch)
2013-08-12 08:55 UTC, Evgeny Bobkin 		none Details | Review

Description Yosef Or Boczko 2013-08-01 16:34:18 UTC 
Is fix the time representation in RTL languages *** in the timer ***.
The solution isn't Unicode characters. I use in direction of GtkWidget.
Comment 1 Yosef Or Boczko 2013-08-01 16:36:18 UTC 
Created attachment 250644 [details]
Screencast - time in Hebrew (RTL) language
Comment 2 Yosef Or Boczko 2013-08-01 16:36:27 UTC 
Created attachment 250645 [details] [review]
Fix time representation in RTL languages in the timer
Comment 3 Yosef Or Boczko 2013-08-01 16:37:45 UTC 
(this also to gnome-3-8 branch)
Comment 4 Evgeny Bobkin 2013-08-11 12:27:07 UTC 
Thank you for this bug report. This is indeed an unwelcomed issue.
Comment 5 Yosef Or Boczko 2013-08-11 12:38:55 UTC 
The issue is in each in gnome-clocks.

run 'env LANG=he_IL.UTF-8 gnome-clocks' and see, in each places in gnome-clocks.
Comment 6 Matthias Clasen 2013-08-11 23:19:24 UTC 
Review of attachment 250645 [details] [review]:

hardcoding ltr is just wrong.
Comment 7 Yosef Or Boczko 2013-08-11 23:21:38 UTC 
I know this hardcode...

what you offers instead this patch?
Comment 8 Evgeny Bobkin 2013-08-12 06:50:43 UTC 
Created attachment 251319 [details] [review]
patch proposal
Comment 9 Evgeny Bobkin 2013-08-12 07:04:40 UTC 
Created attachment 251320 [details] [review]
patch proposal
Comment 10 Paolo Borelli 2013-08-12 07:07:22 UTC 
We should add an ltr marker in the(In reply to comment #6)
> hardcoding ltr is just wrong.


Well, that was my reaction too, but I guess that's what we want here: we want to force the [hh] : [mm] : [ss] spinbuttons to be in this order in all locales.

Evgeny patch looks ok to me
Comment 11 Evgeny Bobkin 2013-08-12 08:55:21 UTC 
Created attachment 251327 [details] [review]
patch proposal for stopwatch
Comment 12 Yosef Or Boczko 2013-08-12 20:46:22 UTC 
patches push to git.
I will open other bug to problem RTL in alarm.