After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705275 - Uses deprecated UPower functionality
Uses deprecated UPower functionality
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-01 10:05 UTC by Jan Alexander Steffens (heftig)
Modified: 2013-08-02 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.41 KB, patch)
2013-08-01 10:05 UTC, Jan Alexander Steffens (heftig)
none Details | Review
power: Use logind to discover CanHibernate (2.50 KB, patch)
2013-08-02 16:11 UTC, Bastien Nocera
committed Details | Review

Description Jan Alexander Steffens (heftig) 2013-08-01 10:05:36 UTC
Created attachment 250603 [details] [review]
patch

UPower's can_hibernate is deprecated and will return an error unless upower is built with --enable-deprecated.

The function is also not defined unless the application defines UPOWER_ENABLE_DEPRECATED, which g-c-c does not do, and the build system currently does not enable the warning (or error) about this.

Attached a half-assed patch porting the power panel to use the systemd-logind interface instead.
Comment 1 Bastien Nocera 2013-08-02 16:11:32 UTC
Created attachment 250722 [details] [review]
power: Use logind to discover CanHibernate

The upower functionality is deprecated and will return an
error unless upower is built with --enable-deprecated.

The function is also not defined unless the application defines
UPOWER_ENABLE_DEPRECATED, which g-c-c does not do, and the build
system currently does not enable the warning (or error) about this.
Comment 2 Bastien Nocera 2013-08-02 16:12:41 UTC
Slightly fixed up, thanks for the patch! :)

Attachment 250722 [details] pushed as 364eee3 - power: Use logind to discover CanHibernate