After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705274 - account: Make sure we don't pass NULL pointer to um realm calc login
account: Make sure we don't pass NULL pointer to um realm calc login
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-01 10:01 UTC by Michael Wood
Modified: 2014-09-02 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account: Make sure we don't pass NULL pointer to um realm calc login (1.10 KB, patch)
2013-08-01 10:01 UTC, Michael Wood 		none Details | Review
account: Make sure we check for NULL on um_realm_object_get_common (1.96 KB, patch)
2013-08-01 10:09 UTC, Michael Wood 		none Details | Review

Description Michael Wood 2013-08-01 10:01:00 UTC 
um_realm_object_get_common can return NULL which would attempted to be
de-ref by um_realm_calculate_login.
Comment 1 Michael Wood 2013-08-01 10:01:02 UTC 
Created attachment 250602 [details] [review]
account: Make sure we don't pass NULL pointer to um realm calc login
Comment 2 Michael Wood 2013-08-01 10:09:15 UTC 
Created attachment 250604 [details] [review]
account: Make sure we check for NULL on um_realm_object_get_common

um_realm_object_get_common can return false so shouldn't be passed to
subsequent functions that will de-reference it.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-01 12:15:51 UTC 
Review of attachment 250604 [details] [review]:

um-realm-manager comes from g-c-c. File it there as well.