After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705202 - Make check fails
Make check fails
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-31 11:11 UTC by Kjartan Maraas
Modified: 2013-08-15 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
More reliable means of checking if object was finalized (26.47 KB, patch)
2013-08-15 08:04 UTC, Stef Walter 		committed Details | Review

Description Kjartan Maraas 2013-07-31 11:11:16 UTC 
I see this when running make check in libsecret:

  /value/boxed:                                                        OK
  /value/to-password:                                                  OK
  /value/to-password-bad-destroy:                                      OK
  /value/to-password-bad-content:                                      OK
  /value/to-password-extra-ref:                                        OK
PASS: test-value
TEST: test-prompt... (pid=7456)
  /prompt/run:                                                         FAIL
GTester: last random seed: R02S688aae4adac740f599435bc10937838f
make[4]: *** [test-c] Terminert
make[4]: Leaving directory `/home/kmaraas/src/gnome/libsecret/libsecret/tests'
make[3]: *** [check-am] Error 2
make[3]: Leaving directory `/home/kmaraas/src/gnome/libsecret/libsecret/tests'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/home/kmaraas/src/gnome/libsecret/libsecret'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/kmaraas/src/gnome/libsecret/libsecret'
make: *** [check-recursive] Error 1
*** Error during phase check of libsecret: ########## Error running make -j2 check *** [32/228]
Comment 1 Stef Walter 2013-08-12 11:33:17 UTC 
Is there a special setting to get jhbuild to run 'make check'? I've tried 'jhbuild buildone --force libsecret' but it doesn't do make check.
Comment 2 Kjartan Maraas 2013-08-14 14:23:15 UTC 
Just pass --check on the command line :-)
Comment 3 Stef Walter 2013-08-15 08:04:37 UTC 
Created attachment 251697 [details] [review]
More reliable means of checking if object was finalized

Don't try to use G_IS_OBJECT() to see if an object was finalized
as this segfaults in corner cases, even with our crafty check
for a pointer within our memory space.
Comment 4 Stef Walter 2013-08-15 08:07:10 UTC 
Attachment 251697 [details] pushed as 9dc2f2c - More reliable means of checking if object was finalized