After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705194 - Failure to decrypt inline encrypted GPG messages
Failure to decrypt inline encrypted GPG messages
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Matthew Barnes
Evolution QA team
: 702176 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-31 09:09 UTC by Milan Crha
Modified: 2013-08-09 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Image test case (226.37 KB, application/mbox)
2013-08-01 09:41 UTC, Matthew Barnes
Details

Description Milan Crha 2013-07-31 09:09:24 UTC
Moving this from a downstream bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=990297

Worked in Evolution 3.8.3 packages, but fails in 3.8.4 packages.

The problem occurrs with GPG encrypted messages, that aren't nested, and use a plain text content-type (or absent content type). In other words, messages where the body consists of
-----BEGIN PGP MESSAGE-----
...
-----END PGP MESSAGE-----
only.

Such messages are displayed with an "encrypted" status icon and a text attachments.

Problem: When clicking "view inline", nothing happens, no decrypted content shown.

With the older evolution 3.8.3 packages, the decrypted content is shown.
Comment 2 Milan Crha 2013-07-31 09:23:51 UTC
I'm assigning this to Matthew, because I do not have his data (why there was no bug report for that change in the first place?).
Comment 3 Kai Engert 2013-07-31 23:43:25 UTC
Thanks Milan, I can confirm the patch mentioned in comment 1 is responsible for the regression.

I'm running a local build of Evolution 3.8.4 with this change reverted, and the problem is gone.
Comment 4 Matthew Barnes 2013-08-01 09:41:33 UTC
Created attachment 250600 [details]
Image test case

Here's the message which was rendered incorrectly prior to the above mentioned commit. It would be good to fix the regression but keep this test case working. I'll take a look at reworking the solution.
Comment 5 Matthew Barnes 2013-08-01 10:00:52 UTC
Copying Kai's comment from bug 701483, since it's more relevant here:

  Matthew, in order to reproduce, you can use the command line to create a
  gpg message, e.g.:

  echo message | gpg --recipient your-own-key-id --encrypt --armor

  In Evolution, compose and paste above plain text into the body (don't select
  encrypt in evolution) and send it to yourself.

I've managed to reproduce the regression myself now.
Comment 7 Kai Engert 2013-08-01 13:21:27 UTC
Wonderful! Now it works even better than before.

Previously, I had to click "view inline" on such attachments. Now they are displayed immediately.

Applied the patch locally, confirmed fixed.
Comment 8 Milan Crha 2013-08-09 12:34:05 UTC
*** Bug 702176 has been marked as a duplicate of this bug. ***