After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705174 - workspaceThumbnail: don't move transient windows for workspaces
workspaceThumbnail: don't move transient windows for workspaces
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-30 20:55 UTC by Bradley Pankow
Modified: 2013-07-30 22:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] workspaceThumbnail: don't move transient windows for workspaces (1.65 KB, patch)
2013-07-30 20:55 UTC, Bradley Pankow 		committed Details | Review

Description Bradley Pankow 2013-07-30 20:55:23 UTC 
Created attachment 250507 [details] [review]
[PATCH] workspaceThumbnail: don't move transient windows for  workspaces

When we shift workspaces to create a blank one for a window or
application, all of the window actors are shifted down.  However, some
of these window actors are transient windows attached to a main window.
When these windows are moved to a different workspace, the main window
is moved along with it. When the main window is moved, these windows
are also moved. This creates a double move of the windows.
This double movement leads to unexpected results where workspaces are
collapsed and windows are in incorrect positions.
This patch prevents movement of these transient windows, only grabbing
the main (ancestor) windows to move to a different workspace.
Comment 1 Bradley Pankow 2013-07-30 21:04:31 UTC 
This problem is most apparent with dynamic workspaces.
The following is one way to replicate this bug:
Enable dynamic workspaces.
Open a gnome-terminal window below a workspace with a window in it.
Open the profile preferences window for gnome-terminal.
Go to overview and drag the window in the workspace above gnome-terminal down to the space between the two workspaces and release to create a new workspace.
Gnome-terminal will be moved down a workspace which should not happen.

This problem happens to any application with transient windows open.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-30 21:09:55 UTC 
Looks correct. Do you have git access?
Comment 3 Bradley Pankow 2013-07-30 21:17:02 UTC 
No, I don't think so.
Comment 4 Bradley Pankow 2013-07-30 21:17:02 UTC 
No, I don't think so.
Comment 5 Bradley Pankow 2013-07-30 21:20:20 UTC 
Hm, I don't know why that happened.  Too bad comments can't be edited.  Well, I'm pretty sure I don't have git access.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-07-30 22:41:46 UTC 
OK, I pushed for you.

Thanks for the patch!