After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705149 - flickr: Bigger thumbnails
flickr: Bigger thumbnails
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-30 14:22 UTC by Debarshi Ray
Modified: 2013-08-21 05:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
flickr: Offer multiple thumbnail sizes (3.64 KB, patch)
2013-07-30 15:32 UTC, Debarshi Ray
needs-work Details | Review
Allow for multiple sizes in thumbnails (3.79 KB, patch)
2013-08-20 22:42 UTC, Juan A. Suarez Romero
committed Details | Review

Description Debarshi Ray 2013-07-30 14:22:56 UTC
We are using Grilo to fetch thumbnails of Flickr items in gnome-photos. The size of the thumbnails shown in the application is 256x256, but the ones obtained via grl_media_get_thumbnail for Flickr are too small. Upscaling them looks bad in the application.

Can we have the option of bigger thumbnails? eg., http://www.flickr.com/photos/debarshiray/9389291103/sizes/n/
Comment 1 Juan A. Suarez Romero 2013-07-30 14:39:48 UTC
Could be we can do as in LastFM album art, and return different sizes of thumbnail as a multi-valued element. Let's say, large, medium and smaller.

User can pick later the one that fits better
Comment 2 Debarshi Ray 2013-07-30 15:32:25 UTC
Created attachment 250480 [details] [review]
flickr: Offer multiple thumbnail sizes
Comment 3 Debarshi Ray 2013-08-19 13:31:30 UTC
Ping.

GNOME 3.9.90 is to be released this week. It would be good to get this solved as soon as possible, because the current thumbnails are too small and look bad in the application.
Comment 4 Juan A. Suarez Romero 2013-08-20 22:41:19 UTC
Review of attachment 250480 [details] [review]:

::: src/flickr/grl-flickr.c
@@ +505,2 @@
   }
 

If you are adding the thumbnail later, you don't need to do it here, because you will have 3 versions.
Comment 5 Juan A. Suarez Romero 2013-08-20 22:42:47 UTC
Created attachment 252481 [details] [review]
Allow for multiple sizes in thumbnails

This patch fixes the previous problem
Comment 6 Juan A. Suarez Romero 2013-08-20 22:44:41 UTC
commit 2beda247809c3a1b334a860c260573c50be6c889
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Tue Jul 30 17:26:51 2013 +0200

    flickr: Offer multiple thumbnail sizes
    
    Currently we are offering the "thumbnail" and "small 320" sizes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705149
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 src/flickr/gflickr.c    | 31 +++++++++++++++++++++++++++++++
 src/flickr/gflickr.h    |  3 +++
 src/flickr/grl-flickr.c | 25 ++++++++++++++++++++-----
 3 files changed, 54 insertions(+), 5 deletions(-)
Comment 7 Debarshi Ray 2013-08-21 05:29:31 UTC
Thanks Juan!