GNOME Bugzilla – Bug 705131
Replace stock icons with named icons
Last modified: 2013-08-20 14:40:54 UTC
This works around GTK bug #702423 which stops the playback icon showing on GTK 3.8 & later. This is also a small first step towards removing deprecated stock items.
Created attachment 250444 [details] [review] Replace stock icons with named icons
Comment on attachment 250444 [details] [review] Replace stock icons with named icons Thanks for working on that!
Created attachment 251711 [details] [review] Remove remaining stock items This removes the arrow on the 'Continue' button in the multiple album dialog partly to conform with the recommendation that buttons just have a label describing their action and partly to avoid having to deal with the RTL variant of the icon. The Alt+N accelerator on 'Cancel' in the infobar is non standard but avoids a clash with the album composer entry. Alt+P for Pause is non standard but avoids a clash with the album artist entry and gives a consistent accelerator for Play/Pause. The disc number entry was missing an accelerator so it is assigned Alt+D.
(In reply to comment #2) > (From update of attachment 250444 [details] [review]) > Thanks for working on that! Are you happy for me to apply that patch? It would be good to get the play icon working again with GTK 3.8
(In reply to comment #3) > Created an attachment (id=251711) [details] [review] > Remove remaining stock items I should remove the underscores from the fake button labels as I think they have 'use-underline' set to FALSE. I've just noticed that we don't have any fake buttons for 'Extract' and 'Stop' should we add some? In English 'Select None' is the longest label for all the buttons and so determines their size but that might not be the case for other languages.
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 250444 [details] [review] [details]) > > Thanks for working on that! > > Are you happy for me to apply that patch? Yes, I've set the patch status as "accepted_commit_now" which means it's fine to be pushed to git.gnome.org. I should have made that more explicit ;)
(In reply to comment #5) > (In reply to comment #3) > > Created an attachment (id=251711) [details] [review] [details] [review] > > Remove remaining stock items > > I should remove the underscores from the fake button labels as I think they > have 'use-underline' set to FALSE. > The real buttons will have underline set to TRUE and their label will contain an underscore so I think you should just add calls to gtk_label_set_use_underline(fake_button, TRUE); Patch looks good otherwise from a quick glance.
Comment on attachment 250444 [details] [review] Replace stock icons with named icons Attachment 250444 [details] pushed as 50c4b53 - Replace stock icons with named icons
(In reply to comment #8) > (From update of attachment 250444 [details] [review]) > Attachment 250444 [details] pushed as 50c4b53 - Replace stock icons with named icons Yay \o/
Created attachment 252416 [details] [review] (In reply to comment #9) > Yay \o/ Thanks! (In reply to comment #7) >The real buttons will have underline set to TRUE and their label will >contain an underscore so I think you should just add calls to >gtk_button_set_use_underline(fake_button, TRUE); I've updated the patch as you suggested.
Comment on attachment 252416 [details] [review] (In reply to comment #9) Thanks, seems good to go now!
Created attachment 252433 [details] [review] Updated patch, added missing GTK_BUTTON casts
Attachment 252433 [details] pushed as c3913c5 - Remove remaining stock items