GNOME Bugzilla – Bug 705115
Calendar visual is broken if you have many tasks and reminders
Last modified: 2014-12-11 17:49:39 UTC
Created attachment 250425 [details] Huge spaces between buttons I have a lot of reminders on my Google Calendar and my Gnome Calendar is synced to it. The Gnome Calendar on top bar seems to have its visual broken, the buttons (to open calendar, open clocks and date/time configurations) are too spaced, there's a huge space between the calendar and the buttons and there's no scroll bar for the tasks/reminders on the right (although it seems that right now it wasn't necessary, but I think I already saw it transcend the line without scroll, but I don't know). See screenshot (My desktop is in portuguese, sorry)
I can confirm this bug as well in GS 3.14. It is of particular annoyance when you have many recurring events. Perhaps the task/event list can be made to scroll up and down once it has reached a particular length?
I would like to work on this error. Can anyone give me a hand on how to fix this.
Stalin: What would that hand exactly do? :) If you have specific questions, please ask specific questions.
Created attachment 292133 [details] [review] Added ScrollView to calendar events
Review of attachment 292133 [details] [review]: Thanks for the patch. Code looks good but as aday said on IRC the separator does stay fixed when the popup gets larger; that needs to be fixed.
Created attachment 292253 [details] [review] Added single ScrollView to calendar events Added single ScrollView to make the calendar events scrollable The calendar height will not go beyond the screen height Calendar events for all periods will be enclosed in a single ScrollView Corrected separator alignment The alignment of separator is set to the bottom of calendar , how can i move it to the start of buttons
Review of attachment 292253 [details] [review]: Looks good to me, nitpick re commit message "Add ..." not "Added ..." in the subject line. Fine to commit with that fixed and an ACK from the designers.
Created attachment 292305 [details] [review] Add single ScrollView to calendar events subject changed
Created attachment 292306 [details] Calendar scroll view
Will this be part of a minor 3.14 update or do we have to wait till 3.16? It looks even more broken with 3.14 than with 3.12.
(In reply to comment #10) > Will this be part of a minor 3.14 update or do we have to wait till 3.16? Considering ongoing work on some major calendar changes for 3.16[0], I'd actually prefer the patch only on 3.14 for now ... [0] https://wiki.gnome.org/Design/OS/Notifications/Redux
Created attachment 292535 [details] [review] Calendar with ScrollView I found some alignment issue in my previous patch so here is the patch with those corrected Moved the separator to top of the buttons while expanding Aligned all the events, All day and events with time, in a straight line
Review of attachment 292535 [details] [review]: Looks good to me ... given Florian's comment I think it makes sense to apply this to the 3.14 branch only for now.
Comment on attachment 292535 [details] [review] Calendar with ScrollView OK pushed to the 3.14 branch.