After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705088 - Make the headerbar a title bar
Make the headerbar a title bar
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-29 16:36 UTC by Stefano Facchini
Modified: 2013-08-16 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make the headerbar a title bar (10.42 KB, patch)
2013-07-29 16:36 UTC, Stefano Facchini
none Details | Review
screenshot (96.39 KB, image/png)
2013-07-29 16:37 UTC, Stefano Facchini
  Details
Make the headerbar a titlebar (5.00 KB, patch)
2013-08-16 09:08 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2013-07-29 16:36:03 UTC
This is the way new apps are supposed to use the header bar - as the title bar for a client-side-decoration world. However, the bar is starting to look a bit busy now, especially in the 
Processes page, maybe a review from a designer could help. The style is still a bit rough (no rounded corners, ugly "close" button").

If this won't get in for 3.10, we could instead set the hide_titlebar_when_maximized flag on the window
Comment 1 Stefano Facchini 2013-07-29 16:36:07 UTC
Created attachment 250383 [details] [review]
Make the headerbar a title bar
Comment 2 Stefano Facchini 2013-07-29 16:37:38 UTC
Created attachment 250384 [details]
screenshot
Comment 3 Robert Roth 2013-07-29 20:43:26 UTC
Yes, the headerbar/titlebar looks cluttered indeed. I have been thinking of moving the load averages to the Resource tab headerbar as is makes more sense there in my opinion (as it's historical data, just like the charts, rather than actual data, like the process tabla), that way the headerbar for resources would also look cluttered (maybe the load averages won't even fit in there, than I'll have to come up with something else).

Based on the above, I'd rather user hide_titlebar_when_maximized for now, until we come up with a good idea (or a designer comes up with a good idea) on how to reduce the titlebar clutter.
Comment 4 Robert Roth 2013-08-01 16:23:16 UTC
Could you rebase the patch to the current trunk? I think it might be OK, as (on the most cluttered processes stack) we have end process, stack switchers, two image buttons and close button. The two image buttons should be smaller as the View button was, so this might end up in 3.10.
Comment 5 Stefano Facchini 2013-08-16 09:08:06 UTC
Created attachment 251796 [details] [review]
Make the headerbar a titlebar

Rebased