GNOME Bugzilla – Bug 705084
UPnP UDA-2.1.5 displays warning about the device icon depth value
Last modified: 2013-08-05 07:26:48 UTC
Created attachment 250378 [details] [review] Fixing device icon to recommended depth value. Device icon used for Rygel uses 32 instead of UPnP recommended depth value of 24. Included patch has the required changes for adding icon support with depth value 24. DLNA CTT : 7.2.28.1 also displays this warning.
I was about to complain that this should be fixed by integrators, but I think we might have misunderstood the alpha channel part of PNG, such as 8bit PNG with alpha still having a depth of 24bit and not 32 (4 * 8).
Yes, guidelines say depth is excluding alpha channel.
Why did you add that 24x24 icon?
@Jens : can you point me to the guideline you are mentioning. Just want to make sure we are referring to the same one.
24x24 icon was not supposed to be in the patch. This was a test code I wrote. Will remove portion that has 24x24 icon addition. But you agree with setting the depth value to 24 instead of 34 for png right ?
Created attachment 250636 [details] [review] Fixing device icon to recommended depth value. Removed test code from the patch
Thanks. 7.2.2 in the 2009 media format docs, truecolor with alpha is defined as 24 bits, that's 7.2.2.2 in the 2011 doc.
Comitted with slightly changed commit message