After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705083 - do not use deprecated loop_run_with_non_fatal_timeout
do not use deprecated loop_run_with_non_fatal_timeout
Status: RESOLVED OBSOLETE
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-29 15:57 UTC by Gustavo Padovan
Modified: 2018-09-21 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: do not use deprecated loop_run_with_non_fatal_timeout (14.13 KB, patch)
2013-07-29 15:57 UTC, Gustavo Padovan 		needs-work Details | Review

Description Gustavo Padovan 2013-07-29 15:57:15 UTC 
Created attachment 250377 [details] [review]
tests: do not use deprecated loop_run_with_non_fatal_timeout

So I half fixed this, I had telepathy and eds backend disabled so I didn't see any other complain about using this deprecated method. All users are now fixed with this patch.

I don't have git access so if you find the patch okay to go upstream please commit it.
Comment 1 Philip Withnall 2013-07-29 21:30:30 UTC 
Review of attachment 250377 [details] [review]:

::: tests/lib/test-utils.vala
@@ +91,3 @@
    */
   [Deprecated (replacement = "loop_run_with_timeout")]
+  public static void loop_run_with_timeout (MainLoop loop,

This looks distinctly like you’ve just run sed over the entire git tree. Have you tested or even compiled this?

There’s a reason all these call sites are calling loop_run_with_non_fatal_timeout() — it’s because the tests don’t terminate the main loop themselves. Changing them to use loop_run_with_timeout() will require adding main_loop.quit() calls in the appropriate places. It’s non-trivial.
Comment 2 GNOME Infrastructure Team 2018-09-21 16:03:40 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/folks/issues/65.