After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705071 - queue2: add support for download buffering if downstream operates in push mode
queue2: add support for download buffering if downstream operates in push mode
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-29 12:07 UTC by Sjoerd Simons
Modified: 2018-02-12 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wip (9.23 KB, patch)
2013-07-29 12:07 UTC, Sjoerd Simons
none Details | Review

Description Sjoerd Simons 2013-07-29 12:07:58 UTC
Created attachment 250361 [details] [review]
wip

tim and others noticed that queue2 doesn't handle seek in push mode. I had a start at adding support for that in queue2 before i discovered typefind does pull-to-push conversion, so push mode is not used in playbin.

Attached is my wip patch, which should really be seen as a strawmen and is completely untested.
Comment 1 Tim-Philipp Müller 2013-07-29 12:12:18 UTC
Clarification: seeks in push mode work just fine, what doesn't work is queue2 operating in download buffering mode while downstream operates in push mode, meaning: it won't serve a seek from existing memory immediately if that's possible, but always pass the seek upstream, like a normal queue.
Comment 2 Tim-Philipp Müller 2018-02-12 19:16:13 UTC
Let's close this. It's unclear whether it actually needs fixing, and there's a new downloadbuffer element now anyway with different code.