GNOME Bugzilla – Bug 705068
Update the GDK and GTK on Win32 to not use deprecated APIs
Last modified: 2013-08-14 00:12:11 UTC
Hi, There seems to be some deprecated APIs that are used in the GDK Win32 backend, so I think it is probably best that its sources should be updated for this regard.
Created attachment 250355 [details] [review] GDK-WIn32: Avoid using deprecated APIs Hi, I have came up with a patch to update the Win32 GDK backend so that we won't use the deprecated APIs in it. By running the test suite test cases against it, I think that the test programs fared at least as well as before the update. With blessings, thank you!
Created attachment 250356 [details] [review] GDK-WIn32: Avoid using deprecated APIs (take ii) Hi, Sorry, I forgot to remove the old code that was commented out in my patch, so upload a new patch for this. With blessings, thank you!
Patch looks fine, but doesn't apply cleanly
Created attachment 250427 [details] [review] GDK-Win32: Avoid using deprecated GDK APIs Hi, Apparently the reason why the patch did no apply cleanly is due to the case that gdk/win32/gdkdevice-virtual.c has DOS/Windows style line endings (CR/LF) for some reason, unlike the other source files which had UNIX line endings (CR). So, I split the the patches into two, the first one would be the one that would apply using "git am < [patch]"...
Created attachment 250428 [details] [review] gdk/win32/gdkdevice-virtual.c: Avoid Using Deprecated GDK APIs ...and this is the patch for the source file that has the CR/LF line endings, so this is one that has to be applied with git am --ignore-whitespace (or something like that). Sorry about the noise. With blessings, thank you!
Created attachment 250515 [details] [review] GTK+ on Win32: Avoid using deprecated API Hi, I have also updated the GTK+ on Win32 sources so that they won't use deprecated APIs, and fixed the build of modules/input/gtkimcontextime.c as it had a wrong include (courtesy of Martin Schlemmer from the GTK-Devel mail list). By running the testsuite of GTK, they seemed to not cause any additional issues. With blessings, thank you!
Review of attachment 250427 [details] [review]: looks ok
Review of attachment 250428 [details] [review]: ok
Review of attachment 250515 [details] [review]: ok
Hi, I have pushed the patches as follows: attachment 250427 [details] [review]: ae79dd70 attachment 250428 [details] [review]: 9072be16 attachment 250515 [details] [review]: 3b82b97e Thanks for the reviews. I will close this bug shortly. With blessings, thank you!