After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705037 - authPrompt: let PAM message wrap if longer than entry
authPrompt: let PAM message wrap if longer than entry
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-28 17:43 UTC by Ray Strode [halfline]
Modified: 2013-07-29 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
authPrompt: let PAM message wrap if longer than entry (2.55 KB, patch)
2013-07-28 17:43 UTC, Ray Strode [halfline]
reviewed Details | Review
authPrompt: let PAM message wrap if longer than entry (3.68 KB, patch)
2013-07-28 22:16 UTC, Ray Strode [halfline]
none Details | Review
authPrompt: let PAM message wrap if longer than entry (3.74 KB, patch)
2013-07-29 21:24 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2013-07-28 17:43:14 UTC
Right now the whole authPrompt spreads out if a PAM message
comes in that longer than the entry.

This commit changes it to wrap instead.
Comment 1 Ray Strode [halfline] 2013-07-28 17:43:16 UTC
Created attachment 250320 [details] [review]
authPrompt: let PAM message wrap if longer than entry
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-07-28 19:49:36 UTC
Review of attachment 250320 [details] [review]:

Why not just set a max-width for the entire auth prompt?
Comment 3 Ray Strode [halfline] 2013-07-28 22:15:45 UTC
well it means having to keep two more numbers in sync in the css file, but that's no big deal, I guess.
Comment 4 Ray Strode [halfline] 2013-07-28 22:16:23 UTC
Created attachment 250336 [details] [review]
authPrompt: let PAM message wrap if longer than entry

Right now the whole authPrompt spreads out if a PAM message
comes in that longer than the entry.

This commit changes it to wrap instead.
Comment 5 Ray Strode [halfline] 2013-07-29 21:24:52 UTC
Created attachment 250398 [details] [review]
authPrompt: let PAM message wrap if longer than entry

Right now the whole authPrompt spreads out if a PAM message
comes in that longer than the entry.

This commit changes it to wrap instead, by forcing the
auth prompt to be a fixed width (slightly bigger than
the entry width was sized to previously).
Comment 6 Ray Strode [halfline] 2013-07-29 21:25:57 UTC
Attachment 250398 [details] pushed as f38d5a9 - authPrompt: let PAM message wrap if longer than entry