After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705013 - Amundsen does not understand CECP undo
Amundsen does not understand CECP undo
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.9.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-28 02:14 UTC by Michael Catanzaro
Modified: 2013-08-18 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop Amundsen support (1.01 KB, patch)
2013-08-18 20:57 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2013-07-28 02:14:50 UTC
From Bug #704993:

"Some supported CECP engines don't properly implement CECP undo/remove commands,
including:

* Boo's Chess
* Fairy-Max
* Amundsen

This leads to an AI hang when these commands are used.  engines.conf needs a
way of indicating that an engine doesn't support undo.  Then either undo should
be prohibited when playing against these engines, or we will need to implement
a workaround (e.g. tell the engine to start a new game, then replay all moves
from the beginning)."

But actually, there was a bug on our end that caused me to believe that the other engines were broken.

Except Amundsen.  Amundsen really IS broken.  There's no point in writing "replay the game from scratch" code to accommodate one broken engine, but we should at least disable Undo so that everything doesn't break horribly.
Comment 1 Michael Catanzaro 2013-08-18 20:57:01 UTC
The following fix has been pushed:
6875200 Drop Amundsen support
Comment 2 Michael Catanzaro 2013-08-18 20:57:03 UTC
Created attachment 252160 [details] [review]
Drop Amundsen support

Amundsen doesn't support the CECP Undo command.  We could work around
this in GNOME Chess, but as Amundsen is really the *only* violator that
I'm aware of, and isn't a very well-known engine, I have no inclination
to do so.  Undo is part of the core protocol and it's not an optional
item.