Created attachment 250233 [details] [review]
context: Use ASCII-only user-agent with version

We were using the application name, which is translated, as the
identifier for our program in the user-agent. This caused some
UPnP servers, such as the one built into Synology NAS to fail
to answer our announcement requests.

Use the program name instead, as this is supposed to be ASCII only.

Furthermore, a version number is expected[1] for that "OS" identifier,
so we add a fake one.

[1]: https://mail.gnome.org/archives/gupnp-list/2011-April/msg00009.html

Created attachment 250235 [details] [review]
Avoid non-ASCII characters in discovery requests

This causes the Synology NAS not to answer our requests.

Created attachment 250236 [details] [review]
context: Use ASCII-only user-agent

We were using the application name, which is translated, as the
identifier for our program in the user-agent. This caused some
UPnP servers, such as the one built into Synology NAS to fail
to answer our announcement requests.

Use the program name instead, as this is supposed to be ASCII only.

Comment on attachment 250233 [details] [review]
context: Use ASCII-only user-agent with version

Looks like the version number isn't required after all.

Let me know if you want me to flesh out the gssdp commit log.

Review of attachment 250235 [details] [review]:

Thanks

Review of attachment 250236 [details] [review]:

Thanks

Review of attachment 250236 [details] [review]:

Thanks

Comment on attachment 250235 [details] [review]
Avoid non-ASCII characters in discovery requests

Attachment 250235 [details] pushed as 7cced1a - Avoid non-ASCII characters in discovery requests

Attachment 250236 [details] pushed as ee09644 - context: Use ASCII-only user-agent