GNOME Bugzilla – Bug 704931
GMenuModel virtual functions don't have out annotation
Last modified: 2013-07-29 21:16:22 UTC
Created attachment 250201 [details] Test GIR file When parsing a GIR file that has a double pointer vapigen should see that as an out parameter. It doesn't, and so then generates the code incorrectly when trying to use that function. Attached is a small GIR file to show the problem that is executed like: $ vapigen --girdir=. --library=test-1.0 Test-1.0.gir Doing that generates a VAPI with the function protoype: public virtual void test_this (GLib.HashTable<void*,void*> hashtable); instead of: public virtual void test_this (out GLib.HashTable<void*,void*> hashtable); This can seen in the GIO vapi file with MenuModel.get_item_links().
Created attachment 250202 [details] Generated VAPI file
Moved over to glib because it seems to be related to missing comments on the virtual functions to designate them as 'out'
Created attachment 250395 [details] [review] Patch to add docs for the functions
Thanks for the patch. Applied.