After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704922 - key-file: do not use deprecated loop_run_with_non_fatal_timeout()
key-file: do not use deprecated loop_run_with_non_fatal_timeout()
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Key file backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-26 09:54 UTC by Gustavo Padovan
Modified: 2013-07-29 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
key-file: do not use deprecated loop_run_with_non_fatal_timeout() (1.63 KB, patch)
2013-07-26 09:54 UTC, Gustavo Padovan 		committed Details | Review

Description Gustavo Padovan 2013-07-26 09:54:08 UTC 
Created attachment 250188 [details] [review]
key-file: do not use deprecated loop_run_with_non_fatal_timeout()

Replace loop_run_with_non_fatal_timeout() by loop_run_with_timeout()
Comment 1 Philip Withnall 2013-07-28 13:33:50 UTC 
Review of attachment 250188 [details] [review]:

Go for it.
Comment 2 Gustavo Padovan 2013-07-29 12:44:03 UTC 
Could you or someone else apply it, as I don't have commit access. Thanks.
Comment 3 Philip Withnall 2013-07-29 13:31:22 UTC 
Comment on attachment 250188 [details] [review]
key-file: do not use deprecated loop_run_with_non_fatal_timeout()

Committed to master with some changes which ensure the tests still actually pass.

commit e43bc1e4b33ba211712fbf0b04e29406d511e983
Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Date:   Fri Jul 26 10:48:33 2013 +0100

    key-file: do not use deprecated loop_run_with_non_fatal_timeout()
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=704922

 NEWS                                     |  1 +
 tests/key-file/individual-retrieval.vala | 16 +++++++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)