GNOME Bugzilla – Bug 704865
Add mpeg2 slice header information to GstMpegVideoMeta
Last modified: 2018-11-03 13:17:02 UTC
Created attachment 250112 [details] [review] mpegvideometa: Add slice information to the GstMpegVideoMeta. +++ This bug was initially created as a clone of Bug #691712 +++
Created attachment 250113 [details] [review] mpegvideoparse: Store slice information in meta if downstream needs it.
any update?
I think this waits for Edward's opinion
Edward, what's your opinion? :)
Is it possible for someone to push these patches?
This can be pushed, but only in 1.5. It's too late and potentially tricky for 1.4
Created attachment 281342 [details] [review] codecparsers: mpegvideometa: Add slice header information to GstMpegVideoMeta. This can be used by the parser elements to provide the slice levelinformation to downstream as per request. This is the same older patch which is rebased on current master.
Created attachment 281344 [details] [review] videoparsers: mpeg2: Store slice information in meta if downstream requested videoparsers: mpeg2: Store slice information in meta if downstream requested Parse the slice headers and store the information as an array of GstMpegVideoMetaSliceInfo with in the GstMpegVideoMeta based on downstream request.If the downstream elements required parsing of slice headers from upstream parser element, then it should be requested explicitly through metadata API specific parameters (Gst.Meta.MpegVideo) via allocation query. patch rebased on current master
The patches are using allocation query for finding out the necessary headers to be parsed (which are needed for downstream elements). This is incomplete because we cannot expect the upstream element to initiate the allocation query always. This should be handled through caps negotiation and that feature development is tracking in https://bugzilla.gnome.org/show_bug.cgi?id=733056.
Proper negotiation support is implemented on top the patches provided here. Please check https://bugzilla.gnome.org/show_bug.cgi?id=733056
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/103.