After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704856 - Add a note about coding style
Add a note about coding style
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-25 11:34 UTC by Stefano Facchini
Modified: 2013-07-25 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add HACKING file with coding style notes (1.23 KB, patch)
2013-07-25 11:34 UTC, Stefano Facchini
committed Details | Review
Add emacs modelines to source files (15.78 KB, patch)
2013-07-25 11:35 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2013-07-25 11:34:13 UTC
Well this is not actually a critical issue :) but it seems that over the years a few different styles piled up and maybe stating clearly something about this will help to gain consistency in the future.

What I wrote in the HACKING file is more or less what seems to me the most common habits, but of course it's only a proposal and could be integrate/expanded/rewritten. The last point is the one I'm most unsure (maybe no space between function name and parenthesis is equally common).

A patch for emacs modelines will follow, too, hoping vim users won't complain ;)
Comment 1 Stefano Facchini 2013-07-25 11:34:59 UTC
Created attachment 250101 [details] [review]
Add HACKING file with coding style notes
Comment 2 Stefano Facchini 2013-07-25 11:35:15 UTC
Created attachment 250102 [details] [review]
Add emacs modelines to source files
Comment 3 Robert Roth 2013-07-25 19:37:14 UTC
Attachment 250101 [details] pushed as 324aaab - Add HACKING file with coding style notes
Attachment 250102 [details] pushed as da116ca - Add emacs modelines to source files