After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704854 - video-player example doesn't cope with uris
video-player example doesn't cope with uris
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-25 10:56 UTC by Sjoerd Simons
Modified: 2013-07-25 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.33 KB, patch)
2013-07-25 10:56 UTC, Sjoerd Simons
accepted-commit_now Details | Review

Description Sjoerd Simons 2013-07-25 10:56:34 UTC
Created attachment 250097 [details] [review]
proposed patch

See attached patch to make it accept both file paths and uris
Comment 1 Lionel Landwerlin 2013-07-25 10:57:59 UTC
Review of attachment 250097 [details] [review]:

Looks good.
Comment 2 Sjoerd Simons 2013-07-25 11:13:50 UTC
commit 2a52c4789077512ce8ad5b7213a3771c92b44411
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Thu Jul 25 12:50:58 2013 +0200

    Handle both uris and local files
    
    Currently it's impossible to play a file from the internet with the
    video-player example. Solve this by recognizing whether a filepath or a
    uri was given and use the appropriate api depending on that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704854