After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704800 - Move a few callbacks where they belong to
Move a few callbacks where they belong to
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-24 11:27 UTC by Stefano Facchini
Modified: 2013-07-24 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move a few callbacks where they belong to (14.56 KB, patch)
2013-07-24 11:27 UTC, Stefano Facchini 		committed Details | Review
Move column resizing callback to procman-app.cpp (3.19 KB, patch)
2013-07-24 11:44 UTC, Stefano Facchini 		none Details | Review
Move column header clicked callback to procman-app.cpp (3.19 KB, patch)
2013-07-24 11:46 UTC, Stefano Facchini 		committed Details | Review
Use an helper method for saving column size (3.64 KB, patch)
2013-07-24 16:14 UTC, Stefano Facchini 		committed Details | Review
Implement timeout API for proctable (10.29 KB, patch)
2013-07-24 16:14 UTC, Stefano Facchini 		committed Details | Review

Description Stefano Facchini 2013-07-24 11:27:29 UTC 
here it comes :)
Comment 1 Stefano Facchini 2013-07-24 11:27:31 UTC 
Created attachment 250027 [details] [review]
Move a few callbacks where they belong to
Comment 2 Stefano Facchini 2013-07-24 11:44:23 UTC 
Created attachment 250029 [details] [review]
Move column resizing callback to procman-app.cpp

For now it seems the best place, since it is called there
Comment 3 Stefano Facchini 2013-07-24 11:46:06 UTC 
Created attachment 250030 [details] [review]
Move column header clicked callback to procman-app.cpp

For now it seems the best place, since it is called there


Er... is't header clicked callback actually
Comment 4 Stefano Facchini 2013-07-24 16:14:00 UTC 
Created attachment 250053 [details] [review]
Use an helper method for saving column size

Instead of sharing the callback
Comment 5 Stefano Facchini 2013-07-24 16:14:12 UTC 
Created attachment 250054 [details] [review]
Implement timeout API for proctable

Since this was the last remaining step, this commit also removes
callbacks.{cpp,h} for good
Comment 6 Robert Roth 2013-07-24 19:53:45 UTC 
Attachment 250027 [details] pushed as 8822986 - Move a few callbacks where they belong to
Attachment 250030 [details] pushed as fc83d69 - Move column header clicked callback to procman-app.cpp
Attachment 250053 [details] pushed as 38d2966 - Use an helper method for saving column size
Attachment 250054 [details] pushed as 9256c45 - Implement timeout API for proctable